refactor: move toolkit to monorepo structure #4342
Merged
+4,891
−4,674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
|
/runIntegrationTests |
hayemaxi
force-pushed
the
restructure3
branch
2 times, most recently
from
90dc07d to
c83b47b
Compare
hayemaxi
force-pushed
the
restructure3
branch
from
c83b47b to
aa81e7b
Compare
hayemaxi
force-pushed
the
restructure3
branch
3 times, most recently
from
a906f33 to
084fef2
Compare
hayemaxi
force-pushed
the
restructure3
branch
from
9a951c9 to
d0e2c38
Compare
justinmk3
reviewed
Jan 31, 2024
hayemaxi
force-pushed
the
restructure3
branch
2 times, most recently
from
16b28e1 to
4b0ff9f
Compare
hayemaxi
force-pushed
the
restructure3
branch
from
4b0ff9f to
81740b2
Compare
…to restructure3
hayemaxi
force-pushed
the
restructure3
branch
2 times, most recently
from
9adfaf5 to
736cb47
Compare
hayemaxi
force-pushed
the
restructure3
branch
from
736cb47 to
64c98e5
Compare
justinmk3
reviewed
Feb 5, 2024
justinmk3
reviewed
Feb 5, 2024
| @@ -26,7 +26,7 @@ import { getTestWindow, resetTestWindow } from './shared/vscode/window' | |||
| import { mapTestErrors, normalizeError, setRunnableTimeout } from './setupUtil' | |||
| import { TelemetryDebounceInfo } from '../shared/vscode/commands2' | |||
|
|
|||
| const testReportDir = join(__dirname, '../../../.test-reports') | |||
| const testReportDir = join(__dirname, '../../../../../.test-reports') // Root project, not subproject | |||
There was a problem hiding this comment.
Future: should concepts like globalSetup.test.ts should be shared ? They solve lots of edge-cases and copy-pasting that across the subprojects adds quality risk.
There was a problem hiding this comment.
yes there should be a shared test setup function/library in a commons folder. Will document.
justinmk3
reviewed
Feb 5, 2024
justinmk3
approved these changes
Feb 5, 2024
|
/runintegrationtests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits restructure our project into a monorepo. Using npm workspaces. The original toolkit extension code now lives under
packages/toolkit/. Additional extensions and common modules will go under thepackages/folder. From this point on, you will need to be more specific with how you run npm scripts. I have added passthroughs for many of the npm scripts in the root folder, e.g.npm run compileandnpm run test. But other lesser used commands may need to be accessed by first going to the subproject directory. Additionally, to run VSCode run and debug configs, you will need to set the subproject folder as your root folder in VSCode (or add it as root folder).Consult https://github.com/aws/aws-toolkit-vscode/blob/21c66e259c88f8c0ca54f8aaff010c301668c683/docs/ARCHITECTURE.md#monorepo-structure for more info on this change.
Remaining work items:
Get VSCode debugging configurations to workFix Github Action-based CI entry points.Ensure coverage works properlyMerge conflicts :((Required after merge?) Fix packaging CILicense
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.